showuon commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r792663973



##########
File path: 
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala
##########
@@ -352,20 +359,28 @@ abstract class EndToEndAuthorizationTest extends 
IntegrationTestHarness with Sas
     // Verify successful produce/consume/describe on another topic using the 
same producer, consumer and adminClient
     val topic2 = "topic2"
     val tp2 = new TopicPartition(topic2, 0)
+
     setReadAndWriteAcls(tp2)
-    sendRecords(producer, numRecords, tp2)
+    // in idempotence producer, we need to create another producer because the 
previous one is in FATEL_ERROR state (due to authorization error)

Review comment:
       I think that's how it is designed. I added more comment for it to make 
it clear:
   `//     // in idempotence producer, we need to create another producer 
because the previous one is in FATEL_ERROR state (due to authorization error)`
   `// If the transaction state in FATEL_ERROR, it'll never transit to other 
state. check TransactionManager#isTransitionValid for detail`
   
   Thank you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to