hachikuji commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r795906556
##########
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##########
@@ -168,7 +168,7 @@ object ConsoleProducer {
.withRequiredArg
.describedAs("request required acks")
.ofType(classOf[java.lang.String])
- .defaultsTo("1")
+ .defaultsTo("-1")
Review comment:
The change makes sense. It looks like it was missed in the KIP. Perhaps
it is worthwhile mentioning the change on the vote thread?
##########
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##########
@@ -253,14 +256,121 @@ public void
testAcksAndIdempotenceForIdempotentProducers() {
Properties invalidProps3 = new Properties() {{
putAll(baseProps);
setProperty(ProducerConfig.ACKS_CONFIG, "0");
- setProperty(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, "true");
}};
assertThrows(
ConfigException.class,
() -> new ProducerConfig(invalidProps3),
"Must set acks to all in order to use the idempotent producer");
}
+ @Test
+ public void testRetriesAndIdempotenceForIdempotentProducers() {
+ Properties baseProps = new Properties() {{
+ setProperty(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG,
"localhost:9999");
+ setProperty(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG,
StringSerializer.class.getName());
+ setProperty(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG,
StringSerializer.class.getName());
+ }};
+
+ Properties validProps = new Properties() {{
+ putAll(baseProps);
+ setProperty(ProducerConfig.RETRIES_CONFIG, "0");
+ setProperty(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, "false");
+ }};
+ ProducerConfig config = new ProducerConfig(validProps);
+ assertFalse(
+ config.getBoolean(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG),
+ "idempotence should be overwritten");
+ assertEquals(
+ 0,
+ config.getInt(ProducerConfig.RETRIES_CONFIG),
+ "retries should be overwritten");
+
+ Properties invalidProps = new Properties() {{
+ putAll(baseProps);
+ setProperty(ProducerConfig.RETRIES_CONFIG, "0");
Review comment:
How about a case where `transactional.id` is set, `enable.idempotence`
is default, and `retries=0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
