hachikuji commented on a change in pull request #11667:
URL: https://github.com/apache/kafka/pull/11667#discussion_r800933651
##########
File path: core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala
##########
@@ -17,41 +17,35 @@
package kafka.server
-import kafka.test.{ClusterConfig, ClusterInstance}
import org.apache.kafka.common.message.ApiVersionsRequestData
import org.apache.kafka.common.protocol.{ApiKeys, Errors}
-import org.apache.kafka.common.requests.ApiVersionsRequest
-import kafka.test.annotation.ClusterTest
-import kafka.test.junit.ClusterTestExtensions
+import org.apache.kafka.common.requests.{ApiVersionsRequest,
ApiVersionsResponse}
import org.junit.jupiter.api.Assertions._
-import org.junit.jupiter.api.BeforeEach
-import org.junit.jupiter.api.extension.ExtendWith
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.ValueSource
-@ExtendWith(value = Array(classOf[ClusterTestExtensions]))
Review comment:
Yes, it's a fair point. I think @cmccabe added the extension logic in
`QuorumTestHarness` after he saw how much effort it was to convert tests to use
`ClusterTestExtensions`. I still tend to see the latter as the way forward in
the long run. It avoids many of the issues with the current integration
frameworks such as all the inconsistent patterns, state sharing conflicts, and
the sort of out-of-control test hierarchy. So I think this is a little bit of a
step backwards.
I was curious, however, about the changes in the validation logic, which
seem reasonable. Why did they become necessary after this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
