dengziming commented on a change in pull request #11667:
URL: https://github.com/apache/kafka/pull/11667#discussion_r801337197
##########
File path: core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala
##########
@@ -17,41 +17,35 @@
package kafka.server
-import kafka.test.{ClusterConfig, ClusterInstance}
import org.apache.kafka.common.message.ApiVersionsRequestData
import org.apache.kafka.common.protocol.{ApiKeys, Errors}
-import org.apache.kafka.common.requests.ApiVersionsRequest
-import kafka.test.annotation.ClusterTest
-import kafka.test.junit.ClusterTestExtensions
+import org.apache.kafka.common.requests.{ApiVersionsRequest,
ApiVersionsResponse}
import org.junit.jupiter.api.Assertions._
-import org.junit.jupiter.api.BeforeEach
-import org.junit.jupiter.api.extension.ExtendWith
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.ValueSource
-@ExtendWith(value = Array(classOf[ClusterTestExtensions]))
Review comment:
I reverted the change for QuorumTestHarness and use
ClusterTestExtensions for the long run.
Currently, we do not support co-resident kraft controllers in
ClusterTestExtensions, so in kraft mode, the controller only advertises
controller APIs, a broker connects to the active controller to learn its
ApiVersions. For forwarded APIs, the broker and controller’s ApiVersions are
intersected to determine the maximal safe set of APIs to advertise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
