[GitHub] [kafka] dajac commented on a change in pull request #11688: KAFKA-13435; Static membership protocol should let the leader skip assignment (KIP-814)

[GitBox]

dajac commented on a change in pull request #11688:
URL: https://github.com/apache/kafka/pull/11688#discussion_r802733093



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##########
@@ -648,10 +648,14 @@ private void maybeUpdateGroupSubscription(String 
assignorName,
         updateGroupSubscription(allSubscribedTopics);
 
         isLeader = true;
-        assignmentSnapshot = metadataSnapshot;
 
-        if (skipAssignment)
+
+        if (skipAssignment) {
+            log.info("Skipped assignment for returning static leader at 
generation {}. The static leader " +
+                "will collect its existing assignment.", 
generation().generationId);

Review comment:
       I would not mention the sync group request. How about `The static leader 
will continue with its existing assignment`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org