dajac commented on a change in pull request #11688:
URL: https://github.com/apache/kafka/pull/11688#discussion_r803838565
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java
##########
@@ -211,7 +211,13 @@ protected void onJoinComplete(int generation, String
memberId, String protocol,
}
@Override
- protected Map<String, ByteBuffer> performAssignment(String leaderId,
String protocol, List<JoinGroupResponseMember> allMemberMetadata) {
+ protected Map<String, ByteBuffer> onLeaderElected(String leaderId,
+ String protocol,
+
List<JoinGroupResponseMember> allMemberMetadata,
+ boolean skipAssignment) {
+ if (skipAssignment)
+ throw new IllegalStateException("Can't skip assignment because
Connect does not support static membership.");
Review comment:
That is definitely debatable. The assertion should help us to catch such
bug early on as system tests would fail instead of potentially releasing a
buggy version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
