dengziming commented on a change in pull request #11746:
URL: https://github.com/apache/kafka/pull/11746#discussion_r804334534
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##########
@@ -524,7 +524,7 @@ static KafkaAdminClient createInternal(AdminClientConfig
config, TimeoutProcesso
config.getLong(AdminClientConfig.RECONNECT_BACKOFF_MAX_MS_CONFIG),
config.getInt(AdminClientConfig.SEND_BUFFER_CONFIG),
config.getInt(AdminClientConfig.RECEIVE_BUFFER_CONFIG),
- (int) TimeUnit.HOURS.toMillis(1),
+ config.getInt(AdminClientConfig.REQUEST_TIMEOUT_MS_CONFIG),
Review comment:
It seems we don't make it very clear about when to use Int and when to
use Long, but `request.timeout.ms` is defined as Integer, the code can be found
in :
```
.define(REQUEST_TIMEOUT_MS_CONFIG,
Type.INT,
30000,
atLeast(0),
Importance.MEDIUM,
REQUEST_TIMEOUT_MS_DOC)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
