dengziming edited a comment on pull request #11746: URL: https://github.com/apache/kafka/pull/11746#issuecomment-1037750296
Hello @dajac @showuon, I found that we set this to a large enough value in KAFKA-5324 so that we can overwrite per-call timeout with a lager value by `AbstractOptions`. I updated the comments and you can have a look. However, in KAFKA-8503(KIP-533, #8011) we change the `AbstractOptions` timeout from `request.timeout.ms` to `default.api.timeout.ms`, this means we no longer need to overwrite `request.timeout.ms`, but need to overwrite `default.api.timeout.ms`, so maybe we can change it back to `REQUEST_TIMEOUT_MS_CONFIG`, what do you think? @dajac @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
