ableegoldman commented on a change in pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#discussion_r808518197
##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##########
@@ -81,14 +81,19 @@ public StreamsBuilder() {
internalStreamsBuilder = new
InternalStreamsBuilder(internalTopologyBuilder);
}
- protected StreamsBuilder(final TopologyConfig topologyConfigs) {
+ /**
+ * Create a {@code StreamsBuilder} instance.
+ *
+ * @param topologyConfigs the streams configs that apply at the
topology level. Please refer to {@link TopologyConfig} for more detail
+ */
+ public StreamsBuilder(final TopologyConfig topologyConfigs) {
topology = getNewTopology(topologyConfigs);
internalTopologyBuilder = topology.internalTopologyBuilder;
internalStreamsBuilder = new
InternalStreamsBuilder(internalTopologyBuilder);
}
protected Topology getNewTopology(final TopologyConfig topologyConfigs) {
Review comment:
Not specific to this PR since it looks like we already have the
TopologyConfig class as a parameter here, but if it's going to be in the public
API then we need to move it out of the current package ie the
`internals.namedtopology` one. Because it's definitely a public API if it's
going to be a parameter of some other public API, and we don't want users to
think that everything under the `internals.namedtopology` is also fair game
since we haven't done the KIP for it yet
cc @guozhangwang @showuon @wcarlson5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
