[GitHub] [kafka] showuon commented on a change in pull request #11705: KAFKA-9847: add config to set default store type

[GitBox]

showuon commented on a change in pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#discussion_r811658823



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedCogroupedKStreamImpl.java
##########
@@ -113,14 +114,23 @@
                     + "]");
             }
 
-            supplier = Stores.persistentTimestampedWindowStore(
-                materialized.storeName(),
-                Duration.ofMillis(retentionPeriod),
-                Duration.ofMillis(windows.timeDifferenceMs()),
-                false
-            );
-
+            if 
(materialized.storeType().equals(Materialized.StoreType.IN_MEMORY)) {
+                supplier = Stores.inMemoryWindowStore(

Review comment:
       Yes, from the [java 
doc](https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/state/Stores.java#L264-L267)
 in the `inMemoryWindowStore`, it said:
   ```
   * Create an in-memory {@link WindowBytesStoreSupplier}
   * This store supplier can be passed into a {@link 
#windowStoreBuilder(WindowBytesStoreSupplier, Serde, Serde)} or
   * {@link #timestampedWindowStoreBuilder(WindowBytesStoreSupplier, Serde, 
Serde)}.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org