showuon commented on a change in pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#discussion_r813644961
##########
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##########
@@ -377,10 +383,21 @@ private void logAll() {
}
/**
- * Log warnings for any unused configurations
+ * Log infos for any unused configurations
*/
public void logUnused() {
- for (String key : unused())
+ Set<String> unusedKeys = unused();
+ //Printing unusedKeys to users should remove unknownKeys
+ unusedKeys.removeAll(unknown());
Review comment:
Before this PR, the `unUsed` set contains both `unUsed` and `unKnown`
configs, because we didn't separate them.
After this PR, we hope we can separate the `unUsed` and `unKnown`, so we
created a new method `unKnown`. Under this situation, I don't think it makes
sense to make `unUsed` set contains both `unUsed` and `unKnown`. That will just
confuse other developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
