[GitHub] [kafka] RivenSun2 commented on a change in pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

[GitBox]

RivenSun2 commented on a change in pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#discussion_r813663958



##########
File path: 
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##########
@@ -377,10 +383,21 @@ private void logAll() {
     }
 
     /**
-     * Log warnings for any unused configurations
+     * Log infos for any unused configurations
      */
     public void logUnused() {
-        for (String key : unused())
+        Set<String> unusedKeys = unused();
+        //Printing unusedKeys to users should remove unknownKeys
+        unusedKeys.removeAll(unknown());

Review comment:
       ok, I agree with you.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org