jsancio commented on a change in pull request #11733:
URL: https://github.com/apache/kafka/pull/11733#discussion_r813998749
##########
File path:
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java
##########
@@ -104,6 +107,14 @@ public PartitionChangeBuilder
setTargetAdding(List<Integer> targetAdding) {
return this;
}
+ public PartitionChangeBuilder
setTargetLeaderRecoveryState(LeaderRecoveryState targetLeaderRecoveryState) {
+ this.targetLeaderRecoveryState = targetLeaderRecoveryState;
+ return this;
+ }
+
+ // TODO: We need to make sure that the LeaderRecoveryState is not lost
when the partition transitions from
Review comment:
Added two tests:
1. Show that going from online to offline to online preserves the leader
recovery state
2. Show that performing an unclean leader election set the leader recovery
state to RECOVERING
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
