jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r814422959
########## File path: core/src/main/scala/kafka/cluster/Partition.scala ########## @@ -542,7 +551,8 @@ class Partition(val topicPartition: TopicPartition, assignment = partitionState.replicas.asScala.map(_.toInt), isr = isr, addingReplicas = addingReplicas, - removingReplicas = removingReplicas + removingReplicas = removingReplicas, + LeaderRecoveryState.RECOVERED Review comment: Yes and no. Unclean leader election is not possible when there is only one replica since the ISR set always equals the replica set. That means that if the replica is online then it will be elected as part of regular election and if it is offline the unclean leader election is a noop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org