philipnee commented on a change in pull request #11797:
URL: https://github.com/apache/kafka/pull/11797#discussion_r815023731
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java
##########
@@ -319,9 +319,11 @@ private void poll(long timeoutMs) {
}
}
- private void readToLogEnd() {
+ private void readToLogEnd(boolean shouldRetry) {
Set<TopicPartition> assignment = consumer.assignment();
- Map<TopicPartition, Long> endOffsets = readEndOffsets(assignment);
+ // readEndOffsets makes listOffsets call to adminClient, if
shouldRetry is set to True, the adminClinet
+ // will retry on RetriableExceptions
Review comment:
Yes! Good call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
