philipnee commented on a change in pull request #11797: URL: https://github.com/apache/kafka/pull/11797#discussion_r815158013
########## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.connect.util; + +import org.apache.kafka.common.errors.RetriableException; +import org.apache.kafka.common.errors.WakeupException; +import org.apache.kafka.common.utils.Utils; +import org.apache.kafka.connect.errors.ConnectException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.concurrent.Callable; + +public class RetryUtil { + private static final Logger log = LoggerFactory.getLogger(RetryUtil.class); + + /** + * The method executes the callable, and performs retries if + * {@link org.apache.kafka.connect.errors.RetriableException} is being thrown. If other types of exceptions is + * caught, then the same exception will be rethrown. If all retries are exhausted, then the last + * exception is wrapped into a {@link org.apache.kafka.connect.errors.ConnectException} and rethrown. + * + * The callable task will be executed at least once. If <code>maxRetries</code> is set to 0, the task will be + * executed exactly once. If <code>maxRetries</code> is set to <code>n</code>, the callable will be executed at + * most <code>n + 1</code> times. + * + * If <code>retryBackoffMs</code> is set to 0, no wait will happen in between the retries. + * + * @param callable The task to execute. + * @param maxRetries Maximum number of retries. + * @param retryBackoffMs Delay time to retry the callable task upon receiving a + * {@link org.apache.kafka.connect.errors.RetriableException}. + * + * @throws ConnectException If the task exhausted all the retries. + */ + public static <T> T retry(Callable<T> callable, long maxRetries, long retryBackoffMs) throws Exception { + Throwable lastError = null; + int attempt = 0; + final long maxAttempts = maxRetries + 1; + while (++attempt <= maxAttempts) { + try { + return callable.call(); + } catch (RetriableException | org.apache.kafka.connect.errors.RetriableException e) { + log.warn("RetriableException caught on attempt {}, retrying automatically up to {} more times. " + + "Reason: {}", attempt, maxRetries - attempt, e.getMessage()); Review comment: We probably should log the exception, in fact. making the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
