showuon commented on a change in pull request #11777:
URL: https://github.com/apache/kafka/pull/11777#discussion_r815282192
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/FenceProducersHandler.java
##########
@@ -76,6 +75,10 @@ public String apiName() {
" when building `InitProducerId` request");
}
InitProducerIdRequestData data = new InitProducerIdRequestData()
+ // Because we never include a producer epoch or ID in this
request, we expect that some errors
+ // (such as PRODUCER_FENCED) will never be returned in the
corresponding broker response.
+ // If we ever modify this logic to include an epoch or
producer ID, we will need to update the
+ // error handling logic for this handler to accommodate these
new errors.
Review comment:
Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
