adamkotwasinski commented on a change in pull request #11843:
URL: https://github.com/apache/kafka/pull/11843#discussion_r820979811



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##########
@@ -420,7 +420,7 @@ private String 
topicIdPartitionsToLogString(Collection<TopicIdPartition> partiti
      * @param topicPartitions  The topicPartitions from the FetchResponse.
      * @param ids              The topic IDs from the FetchResponse.
      * @param version          The version of the FetchResponse.
-     * @return                 True if the full fetch response partitions are 
valid.
+     * @return                 null if the fetch response partitions are 
valid; human-readable problem description otherwise.

Review comment:
       Ah! For the whole time I parsed it as `full (fetch response partitions)` 
and not `(full fetch) response partitions`, as the requests are named `Fetch` 
vs `IncrementalFetch`. Will add it back.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to