adamkotwasinski commented on a change in pull request #11843:
URL: https://github.com/apache/kafka/pull/11843#discussion_r820984291
##########
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##########
@@ -454,7 +454,7 @@ String
verifyFullFetchResponsePartitions(Set<TopicPartition> topicPartitions, Se
* @param topicPartitions The topicPartitions from the FetchResponse.
* @param ids The topic IDs from the FetchResponse.
* @param version The version of the FetchResponse.
- * @return True if the incremental fetch response
partitions are valid.
+ * @return null if the incremental fetch response
partitions are valid; human-readable problem description otherwise.
Review comment:
Yeah, that should be safe, the built string is anyways always returned
if either of them is non-empty. Amended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
