[GitHub] [kafka] dajac commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

[GitBox]

dajac commented on a change in pull request #11942:
URL: https://github.com/apache/kafka/pull/11942#discussion_r834269788



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -1028,6 +1028,7 @@ class ReplicaManager(val config: KafkaConfig,
     var bytesReadable: Long = 0
     var errorReadingData = false
     var hasDivergingEpoch = false
+    var notLocalPreferredReadReplica = false

Review comment:
       Interesting.. I thought that the delayed fetch would return immediately 
in this case. Looking at the code, it does not because the fetch offset is set 
to `UnknownOffsetMetadata` so the delayed fetch just ignore it. I think that 
your patch makes total sense. Let me know when the comments are addressed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org