RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r853664320
##########
clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java:
##########
@@ -202,7 +202,7 @@ public static void addClientSaslSupport(ConfigDef config) {
.define(SaslConfigs.SASL_LOGIN_REFRESH_WINDOW_JITTER,
ConfigDef.Type.DOUBLE, SaslConfigs.DEFAULT_LOGIN_REFRESH_WINDOW_JITTER,
Range.between(0.0, 0.25), ConfigDef.Importance.LOW,
SaslConfigs.SASL_LOGIN_REFRESH_WINDOW_JITTER_DOC)
.define(SaslConfigs.SASL_LOGIN_REFRESH_MIN_PERIOD_SECONDS,
ConfigDef.Type.SHORT, SaslConfigs.DEFAULT_LOGIN_REFRESH_MIN_PERIOD_SECONDS,
Range.between(0, 900), ConfigDef.Importance.LOW,
SaslConfigs.SASL_LOGIN_REFRESH_MIN_PERIOD_SECONDS_DOC)
.define(SaslConfigs.SASL_LOGIN_REFRESH_BUFFER_SECONDS,
ConfigDef.Type.SHORT, SaslConfigs.DEFAULT_LOGIN_REFRESH_BUFFER_SECONDS,
Range.between(0, 3600), ConfigDef.Importance.LOW,
SaslConfigs.SASL_LOGIN_REFRESH_BUFFER_SECONDS_DOC)
- .define(SaslConfigs.SASL_MECHANISM, ConfigDef.Type.STRING,
SaslConfigs.DEFAULT_SASL_MECHANISM, ConfigDef.Importance.MEDIUM,
SaslConfigs.SASL_MECHANISM_DOC)
+ .define(SaslConfigs.SASL_MECHANISM, ConfigDef.Type.STRING,
SaslConfigs.DEFAULT_SASL_MECHANISM, ConfigDef.CompositeValidator.of(new
ConfigDef.NonNullValidator(), new ConfigDef.NonEmptyString()),
ConfigDef.Importance.MEDIUM, SaslConfigs.SASL_MECHANISM_DOC)
Review Comment:
Hi @C0urante
On a second thought, SASL modules are highly flexible and customizable.
And this parameter is not a required parameter, which may cause
compatibility problems when adding a validator.
So to not make things more complicated, remove the validator for this
parameter.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
