RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853664532
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -1324,9 +1324,9 @@ object KafkaConfig { .define(SslEngineFactoryClassProp, CLASS, null, LOW, SslEngineFactoryClassDoc) /** ********* Sasl Configuration ****************/ - .define(SaslMechanismInterBrokerProtocolProp, STRING, Defaults.SaslMechanismInterBrokerProtocol, MEDIUM, SaslMechanismInterBrokerProtocolDoc) + .define(SaslMechanismInterBrokerProtocolProp, STRING, Defaults.SaslMechanismInterBrokerProtocol, ConfigDef.CompositeValidator.of(new ConfigDef.NonNullValidator(), new ConfigDef.NonEmptyString()), MEDIUM, SaslMechanismInterBrokerProtocolDoc) .define(SaslJaasConfigProp, PASSWORD, null, MEDIUM, SaslJaasConfigDoc) - .define(SaslEnabledMechanismsProp, LIST, Defaults.SaslEnabledMechanisms, MEDIUM, SaslEnabledMechanismsDoc) + .define(SaslEnabledMechanismsProp, LIST, Defaults.SaslEnabledMechanisms, new BrokerSecurityConfigs.SaslEnabledMechanismsValidator(), MEDIUM, SaslEnabledMechanismsDoc) Review Comment: On a second thought, SASL modules are highly flexible and customizable. And this parameter is not a required parameter, which may cause compatibility problems when adding a validator. So to not make things more complicated, remove the validator for this parameter. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org