dengziming commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r866465436
##########
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java:
##########
@@ -299,4 +299,30 @@ public static ApiVersion toApiVersion(ApiKeys apiKey) {
.setMinVersion(apiKey.oldestVersion())
.setMaxVersion(apiKey.latestVersion());
}
+
+ public static ApiVersionsResponse apiVersionsResponse(
Review Comment:
This method is identical to another `createApiVersionsResponse` method, so
we can remove it
##########
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala:
##########
@@ -35,6 +35,7 @@ object RawMetaProperties {
val BrokerIdKey = "broker.id"
val NodeIdKey = "node.id"
val VersionKey = "version"
+ val InitialMetadataVersion = "init.metadata.version"
Review Comment:
It seems this variable is not used.
##########
core/src/main/scala/kafka/server/KafkaRaftServer.scala:
##########
@@ -102,6 +106,8 @@ class KafkaRaftServer(
threadNamePrefix,
controllerQuorumVotersFuture,
KafkaRaftServer.configSchema,
+ raftApiVersions,
+ Some(bootstrapMetadata)
Review Comment:
I have 1 concern:
we should also reset featureLevel of `BrokerServer.FinalizedFeatureCache`?
I think featureLevel is similar to ibp of ZK broker, they should be the same as
possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
