mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r869631802


##########
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##########
@@ -55,25 +60,37 @@ public class FeatureControlManager {
      */
     private final TimelineHashMap<String, Short> finalizedVersions;
 
+    /**
+     * The current metadata version
+     */
+    private final TimelineObject<MetadataVersion> metadataVersion;
+
+    /**
+     * Collection of listeners for when features change
+     */
+    private final Map<String, FeatureLevelListener> listeners;
 
     FeatureControlManager(LogContext logContext,
                           QuorumFeatures quorumFeatures,
                           SnapshotRegistry snapshotRegistry) {
         this.log = logContext.logger(FeatureControlManager.class);
         this.quorumFeatures = quorumFeatures;
         this.finalizedVersions = new TimelineHashMap<>(snapshotRegistry, 0);
+        this.metadataVersion = new TimelineObject<>(snapshotRegistry, 
MetadataVersion.UNINITIALIZED);

Review Comment:
   UNINITIALIZED was added since we need a non-null object to initialize the 
TimelineObject



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to