hachikuji commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r881002654
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -318,6 +325,11 @@ public class KafkaAdminClient extends AdminClient {
private final Logger log;
private final LogContext logContext;
+ /**
+ * The name of the internal raft metadata topic
+ */
+ private static final String METADATA_TOPIC_NAME = "__cluster_metadata";
Review Comment:
Hmm, I hadn't really been thinking about the fact that we would have to
expose this to the client. I guess that is the consequence of having such a
general `DescribeQuorum` API. This makes me wonder if we ought to be more
forward looking with the naming here. Suppose that we ultimately decide to use
raft for partition replication as well. Then we might want to be able to use
`DescribeQuorum` for user partitions as well, but we haven't given ourselves a
lot of room for extension in the `describeQuorum` API. Would it make sense to
make the new API more specific to the metadata quorum?
```java
public DescribeMetadataQuorumResult
describeMetadataQuorum(DescribeMetadataQuorumOptions options)
```
It is more verbose, but it is also clearer.
We should also move this constant to
`org.apache.kafka.common.internals.Topic`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
