niket-goel commented on code in PR #12206: URL: https://github.com/apache/kafka/pull/12206#discussion_r881043900
########## clients/src/main/java/org/apache/kafka/common/utils/QuorumInfo.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common; + +import java.util.List; + +/** + * This is used to describe per-partition state in the DescribeQuorumResponse. + */ +public class QuorumInfo { + private final String topic; + private final Integer leaderId; + private final List<ReplicaState> voters; + private final List<ReplicaState> observers; + + public QuorumInfo(String topic, Integer leaderId, List<ReplicaState> voters, List<ReplicaState> observers) { + this.topic = topic; + this.leaderId = leaderId; + this.voters = voters; + this.observers = observers; + } + + public String topic() { + return topic; + } + + public Integer leaderId() { + return leaderId; + } + + public List<ReplicaState> voters() { + return voters; + } + + public List<ReplicaState> observers() { + return observers; + } + + public static class ReplicaState { + private final int replicaId; + private final long logEndOffset; + private final long lastFetchTimeMs; + private final long lastCaughtUpTimeMs; + + public ReplicaState(int replicaId, long logEndOffset) { Review Comment: Sorry, I did not get what you meant. We need access to it in `KafkaAdminClient.java`. Are you suggesting it be protected? or have a builder instead of exposing the constructor? Or building it through the `QuorumInfo` itself? ########## clients/src/main/java/org/apache/kafka/common/utils/QuorumInfo.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common; + +import java.util.List; + +/** + * This is used to describe per-partition state in the DescribeQuorumResponse. + */ +public class QuorumInfo { + private final String topic; + private final Integer leaderId; + private final List<ReplicaState> voters; + private final List<ReplicaState> observers; + + public QuorumInfo(String topic, Integer leaderId, List<ReplicaState> voters, List<ReplicaState> observers) { + this.topic = topic; + this.leaderId = leaderId; + this.voters = voters; + this.observers = observers; + } + + public String topic() { + return topic; + } + + public Integer leaderId() { + return leaderId; + } + + public List<ReplicaState> voters() { + return voters; + } + + public List<ReplicaState> observers() { + return observers; + } + + public static class ReplicaState { + private final int replicaId; + private final long logEndOffset; + private final long lastFetchTimeMs; + private final long lastCaughtUpTimeMs; + + public ReplicaState(int replicaId, long logEndOffset) { + this.replicaId = replicaId; + this.logEndOffset = logEndOffset; + this.lastFetchTimeMs = -1; + this.lastCaughtUpTimeMs = -1; + } + + public ReplicaState(int replicaId, long logEndOffset, + long lastFetchTimeMs, long lastCaughtUpTimeMs) { + this.replicaId = replicaId; + this.logEndOffset = logEndOffset; + this.lastFetchTimeMs = lastFetchTimeMs; + this.lastCaughtUpTimeMs = lastCaughtUpTimeMs; + } + + public int replicaId() { + return replicaId; + } + + public long logEndOffset() { + return logEndOffset; + } + + public long lastFetchTimeMs() { Review Comment: `OptionalLong` makes sense. Let me make that change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
