On Nov 7, 2004, at 7:17 PM, Miguel wrote:
Turning that from ignore to warning gives quite a few more warnings that are in the vein of:
Severity Description Resource In Folder Location Read access to enclosing field FileManager.fileName is emulated by a synthetic accessor method. Increasing its visibility will improve your performance FileManager.java Jmol/src/org/jmol/viewer line 376
The suggested fix for that is to "change modifier of fileName to default visibility", i.e., change from 'private String fileName' to 'String fileName'.
Since it mentions the possibility of improved performance, I wonder whether we should 'quick fix' these too?
Yes, we can remove the 'private' visibility modifier from these.
The performance difference will generally not be measurable, but the code
will be slightly smaller.
Done.
I also notice a lot of warnings in the PovraySaver.java (unnecessary casts to float for an expression of type float).
Before I remove those, I decided to download Povray for Mac and try the PovraySaver. The structure that renders looks messed up (multiple structures slightly displaced).
Is the Povray conversion broken, or does it have something to do with the Mac version (3.6)?
Ren�
------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_idU88&alloc_id065&op=click _______________________________________________ Jmol-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jmol-developers
