This change looks good - it'll probably take a perf hit in some cases, but
that seems to be ok, since those cases were causing problems anyway (such as
when the contents are floated outside of the element).

--John


On Mon, May 18, 2009 at 9:54 AM, Brandon Aaron <[email protected]>wrote:

>
> Unfortunately checking for 0 or > 0 on both is not at straightforward
> as we'd like it to be. There are scenarios where one dimensions can be
> 0 and the element is still "visible". Or in the case of #4512, one
> dimensions can be > 0 and the element is still "hidden". o_O
>
> I've replied on the ticket and attached a patch that fixes these edge
> cases. In summary I use the dimensions check for speed and if the
> result is ambiguous then I fall back to checking the display property.
>
> --
> Brandon Aaron
>
>
> On Mon, May 18, 2009 at 8:19 AM, Projet Master 104 - Contruction d'un
> portefeuille d'actions <[email protected]> wrote:
> >
> > Hi brandon,
> >
> > I've also found this bug on ie6 and post a comment in the bug tracker.
> >
> > 1) I think the following code (jQuery/src/selector.js at line 984) :
> > return elem.offsetWidth > 0 || elem.offsetHeight > 0;
> > should be replaced by :
> > return elem.offsetWidth > 0 && elem.offsetHeight > 0;
> >
> > 2) Moreover, in your previous changeset (6337) the following code :
> > return elem.offsetWidth === 0 || elem.offsetHeight === 0;
> > is replaced by this :
> > return elem.offsetWidth === 0 && elem.offsetHeight === 0;
> >
> > This code will not work on ie6 as TR tr width > 0 even if its display
> > is none.
> >
> > Benoit
> >
> >
> > >
> >
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"jQuery Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/jquery-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to