Hi Dan,
Thanks for all the input.
As far as the unbind behavior...that was mainly for the demo, so that if you
switch from click to mouseover in the demo, it will unbind the previous
setting. No need for that really.
I'll work on the other stuff and get it ready for version 1.01.
-- Josh
----- Original Message -----
From: "Dan G. Switzer, II" <[EMAIL PROTECTED]>
To: <jquery-en@googlegroups.com>
Sent: Friday, July 13, 2007 5:32 AM
Subject: [jQuery] Re: ANNOUNCE: ClockPick, a timepicker plugin
Josh,
I've whipped up a timepicker plugin over the last few days, and I'm hoping
some folks on here using Macs might try the demo and let me know how it
works, especially Safari.
http://www.oakcitygraphics.com/jquery/clockpick/ClockPick.cfm
Most of the kinks have been worked out, there is still a bit of work to be
done, but it works well in IE6 and FF. If anyone has problems in other
browsers please let me know.
Comments/suggestions welcome!
As already stated, I really like the UI approach you took with this. Just
a
couple of quick comments/suggestions:
1) Right now the time pop-up doesn't go away unless you pick a time. I'd
add
some code so that if the user isn't over one of the time layers it'll go
away after XXX milliseconds. I'd make that configurable.
2) The line jQuery(this).unbind(); removes *all* bound events. Since
you're
calling this in your plug-in, it would break any existing behaviors
attached
to the field (someone may want multiple behaviors attached to an element.)
3) I think I'd remove this code and leave it for the user to CSS how the
elements should appear.
// mouseover to pointer
jQuery(this).hover(
function() { jQuery(this).css("cursor","pointer"); },
function() { jQuery(this).css("cursor","auto"); }
);
4) I'd love to see keyboard behavior eventually added.
5) I might change your "click" behavior example to "focus". That way if
you
move to the field via the keyboard, it'll still pop-up the time layers.
6) It feels a little sluggish to me in FF2. It's zippy in IE, but in FF2
there's a delay mousing over each hour element.
7) I might add an option to allow even distribution of the hours. Right
now
AM is on the left and PM is on the right. It might be nice to just end up
having even columns.
8) You might want to check the pop-up layer if the time box is near the
bottom or right of the viewport. I always prefer pop-ups that stay on my
viewport. I don't like users having to scroll to get to a pop-up element.
Overall this is a great start to a what looks to be a very useful plug-in.
-Dan
