As a quick workaround, does the following work:
spinner: '<span><img src="/css/images/misc/spinner.gif" /></span>'
Or, you could also not touch the default spinner, but add the image as
background-image:
.ui-tabs-load em {
padding-left: 20px;
background: url(/css/images/misc/spinner.gif) no-repeat;
}
Interestingly you're already keeping the image inside the css
folder ;)
Nevertheless, despite the workarounds, I'm going to fix this bug of
course.
--Klaus
On 10 Feb., 19:44, brian <bally.z...@gmail.com> wrote:
> On Tue, Feb 10, 2009 at 4:21 AM, Klaus Hartl <klaus.ha...@googlemail.com>
> wrote:
>
> > Hello Brian, would you mind to file a bug for this?
>
> > --Klaus
>
> I don't mind at all.In fact, I've found a partial fix. Not really a
> fix, but a lead, anyway. However, I don't see any obvious way to reset
> my forgotten password for Trac. There really should be a link for that
> on the login page.
>
> I'm referring to the UI Trac site, not the main jquery bugtracker, for
> which I do have my password. I did search Trac before posting, btw,
> and found a similar bug but it's a year old and closed.
>
> Anyway, I'll leave some info here, for now.
>
> I altered the cleanup method (line 494) of ui.tabs.js
>
> var cleanup = function() {
> self.$tabs.filter('.ui-tabs-loading').removeClass('ui-tabs-loading')
> .each(function() {
> if (o.spinner)
>
> //inner(this).parent().html(inner(this).data('label.tabs'));
>
> inner(this).html(inner(this).find('em').data('label.tabs'));
> });
> self.xhr = null;
>
> };
>
> While the data is stored inside the EM, inner(this) here is actually
> the A tag. The change above causes the spinner to be properly removed
> on tab load.
>
> But, when I remove the spinner option and let the default text be
> used, inner(this) is then an EM tag and the "loading ..." text is not
> removed when a tab loads (with my change in place)
>
> So, the best I can figure out so far is that the 'ui-tabs-loading'
> class is applied to a different element--A or EM--depending on what's
> inside the tab's A tag. Thus, the filter in cleanup() will return a
> different element. Or something like that. I'm going to pursue that a
> bit more.
>
> I did wonder if the problem was related to nesting an img inside an
> em, but switching the doctype had no effect.
>
> If I figure out how to log in to UI Trac I'll post all of this there
> along with anything else I uncover.
