The CSS workaround workd for me. The class was just wrong

use: .ui-tabs-loading em
instead of: .ui-tabs-load em

and: .tabs({ spinner: '.'}); (used a dot so the text will hide behind
the image)



On Feb 10, 7:08 pm, brian <bally.z...@gmail.com> wrote:
> On Tue, Feb 10, 2009 at 4:12 PM, Klaus Hartl <klaus.ha...@googlemail.com> 
> wrote:
>
> > As a quick workaround, does the following work:
>
> > spinner: '<span><img src="/css/images/misc/spinner.gif" /></span>'
>
> no difference
>
> > Or, you could also not touch the default spinner, but add the image as
> > background-image:
>
> > .ui-tabs-load em {
> >    padding-left: 20px;
> >    background: url(/css/images/misc/spinner.gif) no-repeat;
> > }
>
> Not this, either. Testing with the stock ui.tabs.js of course.
>
> > Interestingly you're already keeping the image inside the css
> > folder ;)
>
> > Nevertheless, despite the workarounds, I'm going to fix this bug of
> > course.
>
> I did originally think the problem was that it was an IMG tag but it
> seems to be something quite different. The filter() in cleanup() is
> returning a different element. I thought that it might be that the
> 'ui-tabs-loading' class might be attached to a different element but
> of course, it's attached directly to the A, so that doesn't seem to be
> it.
>
> I did some logging:
>
> var cleanup = function() {
>         self.$tabs.filter('.ui-tabs-loading').removeClass('ui-tabs-loading')
>                         .each(function() {
>                                 if (o.spinner)
>                                         console.log(inner(this)[0].tagName);
>                                         
> inner(this).parent().html(inner(this).data('label.tabs'));
>                         });
>         self.xhr = null;
>
> };
>
> no spinner option (default loading text):
> EM
>
> spinner: '<img src="/css/images/misc/spinner.gif" />'
> A
>
> spinner: '<span><img src="/css/images/misc/spinner.gif" /></span>'
> A
>
> I changed the EM to SPAN:
>
> if (o.spinner) {
>         var label = inner(a).html();
>         inner(a).wrapInner('<span></span>')
>                 .find('span').data('label.tabs', label).html(o.spinner);
>
> }
>
> no spinner option (default loading text):
> SPAN
>
> spinner: '<img src="/css/images/misc/spinner.gif" />'
> A

Reply via email to