On Monday, October 31, 2011 12:27:09 PM UTC-4, Jake Verbaten wrote:
>
> Line 
> 19<https://github.com/aviat4ion/kis-js/blob/master/src/modules/event.js#L19> 
> You 
> already checked the method exists, why check again
>
>  It made sense at the time :/ 

> Line 
> 40<http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-eventtarget>
>  Your 
> calling `callback.apply(arguments)` instead of 
> `callback.apply(arguments[0])` 
>
 Corrected

> Line 
> 45<https://github.com/aviat4ion/kis-js/blob/master/src/modules/event.js#L45> 
> Removing 
> the event listener to stop double-bind is non-standard behaviour
> <https://github.com/aviat4ion/kis-js/blob/master/src/modules/event.js#L137>
>
  I'm not aware of standard behavior

> Line 
> 137<https://github.com/aviat4ion/kis-js/blob/master/src/modules/event.js#L137>
>  Contains 
> a "//todo implement it". Don't make it part of the public API if it doesnt 
> work
>
 Good point...no longer public 

>
> Where is event.fire/dispatch ?
>
  Hmm...I'm not sure how to set that up.

>
> You can also look at my 
> EventTarget<http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-eventtarget>
>  
> Implementation<https://github.com/Raynos/DOM-shim/tree/master/src/interfaces/EventTarget/props>
>  for 
> IE8.
>

Thanks, but I'd rather not have to extract everything from your DOMShim 
framework.  My goal here is only to shim IE 8
 

-- 
To view archived discussions from the original JSMentors Mailman list: 
http://www.mail-archive.com/jsmentors@jsmentors.com/

To search via a non-Google archive, visit here: 
http://www.mail-archive.com/jsmentors@googlegroups.com/

To unsubscribe from this group, send email to
jsmentors+unsubscr...@googlegroups.com

Reply via email to