These diffs are too big for me to review all at once. There are lots of separate changes within one diff. Can you split them up, ideally in order of least discussion required -> most discussion required.
thanks, Andy http://codereview.appspot.com/129041/diff/1/2 File javascript/json-template.js (right): http://codereview.appspot.com/129041/diff/1/2#newcode96 Line 96: 'attr': function(s) { this name can't be changed incompatibly http://codereview.appspot.com/129041/diff/1/2#newcode157 Line 157: new_context= null; On 2009/10/07 01:47:00, sroussey wrote: > I have push() always push. Push and pop will thus always match Why would this be necessary? Also may be a compatibility problem. http://codereview.appspot.com/129041/diff/1/2#newcode478 Line 478: }; On 2009/10/07 01:47:00, sroussey wrote: > I think this is an optimization -- not recreating on each loop below. Depends on > the implementation of JS, which most tend not to optimize this type of stuff > (even though most compilers do). OK, this is probably good. But it should be split out into separate changes. http://codereview.appspot.com/129041 --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "JSON Template" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/json-template?hl=en -~----------~----~----~----~------~----~------~--~---
