> http://codereview.appspot.com/129041/diff/1/2#newcode96 > Line 96: 'attr': function(s) { > this name can't be changed incompatibly
The others alias to it. It's fine. I found other people renaming it (removing the old), but I just added it in. > http://codereview.appspot.com/129041/diff/1/2#newcode157 > Line 157: new_context= null; > On 2009/10/07 01:47:00, sroussey wrote: > > > I have push() always push. Push and pop will thus always match > > Why would this be necessary? Also may be a compatibility problem. In JS, users don't have access to make an compatibility problem. It sunk a bunch of my time before I noticed that the stack's push and pop weren't standard, and that the push would not push, not cause an error. There is a similar issue with how the context is mutated in a repeated section, which was difficult to understand. It is made worse in the PHP implementation (which tries very much to be a close copy), since that is marked as an iterator, thus implying an iterator contract. There are no notes that if the iteration were to stop for some reason, that the context stack would be hosed. One other implementation of json-template that I found (in nitro?) had a far clearer way of dealing with it, that they version had plenty of other bugs. Sigh. > OK, this is probably good. But it should be split out into separate > changes. Yeah, easier to deal with patchsets than to split one that already exists. So quilt won't be much help. I'm new to Mercurial, I look at mercurial queues, but again, I don't think it will help at this point. Though might help avoid things in the future. I should learn how to branch things in Mercurial on Google code... Then you could have been moving stuff mainline as you saw fit. But we are where we are... --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "JSON Template" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/json-template?hl=en -~----------~----~----~----~------~----~------~--~---
