And I think the correct way to get those in is to remind committers
that they are there - which is exactly also what Harry did. Now I
couldn't forget about them even if I wanted to, so it's very likely
that in my next "let's go through the JIRA" -round I'll attend to
these - unless someone else gets there first ;-)
/Janne
On Apr 13, 2008, at 09:58 , Harry Metske wrote:
exactly
2008/4/13, Craig L Russell <[EMAIL PROTECTED]>:
The issue here, if I understand the comment, is that Harry has a
proposed
fix and attached patches to the JIRAs and would like one of the
committers
to review and provide feedback. If the fix appears to be correct,
then
whoever reviews it could just commit it.
Can anyone look at Harry's patch and commit or comment on it?
Craig
On Apr 12, 2008, at 10:23 AM, Janne Jalkanen wrote:
*shrug* when I decide to fix something, I just pick something and
work
on it. I don't remember all the issues and whether they have
patches or
not. I don't certainly go through all the issues first (JIRA is
way too
slow for that). I can't say what the others do, but that's the
way I work.
I guess the only way to get them fixed is to bug the list about
them so
that people remember that they exist :-)
/Janne
On 12 Apr 2008, at 19:52, Harry Metske wrote:
I understand there are many more open issues, but what I meant
is that
these
three issues have patches attached for quite a while, while all the
other
issues have not.
Having the patches not in the base for such a long time requires
me to
keep
changing the patches when sources get changed by other patches.
(for
example
JSPWIKI-242 is a candidate)
But I might be misunderstanding some things ?
regards,
Harry
2008/4/12, Janne Jalkanen <[EMAIL PROTECTED]>:
They are all tagged for 2.8... So eventually, yeah.
There are currently 40+ open issues for 2.8 (just went through the
unassigned list). But I am not going through them in any
particular
order.
/Janne
On Apr 12, 2008, at 18:52 , Harry Metske wrote:
Hi committers,
the jira issues JSPWIKI-10 JSPWIKI-50 and JSPWIKI-100 are planned
for
2.8
and have patches attached.
Are there any plans to incorporate these patches ?
regards,
Harry
--
met vriendelijke groet,
Harry Metske
Telnr. +31-548-512395
Mobile +31-6-51898081
--
met vriendelijke groet,
Harry Metske
Telnr. +31-548-512395
Mobile +31-6-51898081
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/
jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!
--
met vriendelijke groet,
Harry Metske
Telnr. +31-548-512395
Mobile +31-6-51898081
