[
https://issues.apache.org/jira/browse/JSPWIKI-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656290#action_12656290
]
Harry Metske commented on JSPWIKI-291:
--------------------------------------
I started "converting" the AbstractReferrealPlugin, it uses regexps for the
include and exclude parameters.
At least that's what is documented at
http://www.jspwiki.org/wiki/AbstractReferralPlugin.
However, using oro for the patterns we do not only allow regexps but also
globbing and more (as Janne already expected).
So, the JUnit test fails because it uses '*7' as a pattern, which is a valid
glob pattern but _not_ valid regex pattern. (changing all '*' to '.*' makes
the JUnit test succeed again).
So what do we do with this ?
Accept the incompatibility with the current behavior, and document that we now
really require a valid regexp ?
> Replace ORO regexp library with Java 5 regexps
> ----------------------------------------------
>
> Key: JSPWIKI-291
> URL: https://issues.apache.org/jira/browse/JSPWIKI-291
> Project: JSPWiki
> Issue Type: Task
> Components: Core & storage, Filters, Plugins
> Reporter: Janne Jalkanen
> Priority: Trivial
> Fix For: 3.0
>
> Attachments: denouncePlugin.patch
>
>
> Now that Java has a good regexp library, it might be a good idea to get rid
> of the oro library, as it reduces our dependencies of external libraries.
> This should be a relatively easy task, except when Glob patterns are being
> used, or when oro-specific regexps are used.
> No particular release is targeted; whenever we got time. This would be a
> nice low-hanging fruit for someone to start contributing to JSPWiki with...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
