[
https://issues.apache.org/jira/browse/JSPWIKI-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harry Metske updated JSPWIKI-291:
---------------------------------
Attachment: JSPWiki-291.patch
Oke, a short summary, the following classes were patched :
- SpamFilter, difficult to test for me
- JSPWikiMarkupParser, the heart and soul of JSPWiki, it now only fails the
testCCLinkWithScandics() method now, probably has something to do with code
pages => can somebody have a look at this ?
- AbstractReferralPlugin, fixed, it now uses
com.ecyrd.jspwiki.util.RegExpUtil.globToPerl5() to convert globs to perl5 regexp
- IfPlugin
- PluginManager
- ReferredPagesPlugin (I created a JUnit test for it, it didn't have one yet)
- RCSFileProvider
New classes:
- RegExpUtil, new class lifted over from the oro package (any special licensing
issues here ?)
- ReferredPagesPluginTest
Deleted the oro.jar from the classpath.
I'd like some review/testing here before committing.
I attached the patch
regards,
Harry
> Replace ORO regexp library with Java 5 regexps
> ----------------------------------------------
>
> Key: JSPWIKI-291
> URL: https://issues.apache.org/jira/browse/JSPWIKI-291
> Project: JSPWiki
> Issue Type: Task
> Components: Core & storage, Filters, Plugins
> Reporter: Janne Jalkanen
> Priority: Trivial
> Fix For: 3.0
>
> Attachments: denouncePlugin.patch, JSPWiki-291.patch
>
>
> Now that Java has a good regexp library, it might be a good idea to get rid
> of the oro library, as it reduces our dependencies of external libraries.
> This should be a relatively easy task, except when Glob patterns are being
> used, or when oro-specific regexps are used.
> No particular release is targeted; whenever we got time. This would be a
> nice low-hanging fruit for someone to start contributing to JSPWiki with...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
