Looks nice; though a couple of issues:
* Code is not formatted according to JSPWiki coding guidelines (e.g.
it uses tabs)
* This is a fairly large contribution, so I think an ICLA or a
Software Grant is required
So no opposition from me, if the above are addressed (including the
unit tests).
/Janne
On 8 Aug 2009, at 15:36, Harry Metske wrote:
Hi there,
Andre has contributed a PageViewPlugin.
Looks to me a good candidate to takeinto the core distribution, it
just
needs some additional JUnit tests.
Any thoughts ?
See http://www.jspwiki.org/wiki/PageViewPlugin
regards,
Harry