I don't believe either it would be too late to integrate in 2.8, since
it would be just a new plugin and does not change existing APIs in any
way. It should also work quite unmodified in 3.0, though it would
make sense to store the data in JCR.
(Note, however, that there's still a good reason to store page view
counts in a separate file: performance. Having a database write
(possibly several) for each read would be very heavy. Better to
journal it and keep a latest count in memory; then upon startup read
the journal back in. JCR does not have the concept of appending to a
Property either.)
/Janne
On 9 Aug 2009, at 11:04, Harry Metske wrote:
Florian,
why would it be too late for integration in 2.8 ?
Storing the page counters in a flat file is indeed something to
reconsider,
I agree with you about JCR, in 3.0 it should support a clustered
wiki environment.
regards,
Harry
2009/8/9 Florian Holeczek <[email protected]>
Hallo Harry,
it seems to be a very nice plugin, indeed.
However, for 2.8 it's too late for integrating it, and for 3.x its
persistency code should be changed. Now that we're using JCR, a page
view count is a typical candidate for another page metadata to be
stored directly in the content repository and not in an extra file on
disk. But the plugin frontend looks nice to me!
best regards
Florian
Ursprüngliche Nachricht vom 08.08.2009 um 16:36:
Hi there,
Andre has contributed a PageViewPlugin.
Looks to me a good candidate to takeinto the core distribution, it
just
needs some additional JUnit tests.
Any thoughts ?
See http://www.jspwiki.org/wiki/PageViewPlugin
regards,
Harry
