For 3.0, it might be nice to store the contents in the repository as opposed to the work directory. That way you don't lose it accidentally if you empty the workdir or move the machine or something. Workdir is supposed to be a place for things which can be recovered...

/Janne

On 30 Aug 2009, at 13:11, Harry Metske wrote:

The Plugin is in the core now for 2.8.
I'm working on the 3.0 version, but it requires some more adjustments (like
replace oro regexp with Java 5 regexp).

regards,
Harry

2009/8/26 Harry Metske <[email protected]>

Hi,
Andre has sent a signed ICLA to ASF's secretary.
So I'd like to add this plugin to the core.
I will add some testcases and hope to commit it somewhere next week if
there aren't any objections.

regards,
Harry

2009/8/12 Harry Metske <[email protected]>

I sent Andre a direct email, and got an out-of-office reply, we should wait
a couple of weeks still.
regards,
Harry


2009/8/9 Janne Jalkanen <[email protected]>


An improvement would be that it could also listen to the
WikiEngineEvent.SHUTDOWN to be on the safe side.

Is Andre on this list? Would you mind contributing your code to us?

/Janne


On 9 Aug 2009, at 11:59, Harry Metske wrote:

the plugin spawns a separate thread when it first initializes (using a
static var).The thread saves the in-memory counts to a file each 5
minutes.

Harry

2009/8/9 Florian Holeczek <[email protected]>

Hi all,

I don't believe either it would be too late to integrate in 2.8, since
it would be just a new plugin and does not change existing APIs in any
way.


ok, fine then! :-) Was thinking of the policy to only integrate bugfix code into a stable branch, but indeed, it's a non-invasive change.

(Note, however, that there's still a good reason to store page view
counts in a separate file: performance. Having a database write
(possibly several) for each read would be very heavy.  Better to
journal it and keep a latest count in memory; then upon startup read the journal back in. JCR does not have the concept of appending to a
Property either.)


AFAIK this is just the way Andre has implemented it :-)

regards
Florian






Reply via email to