On 4 June 2014 11:02, Nate Finch <nate.fi...@canonical.com> wrote:
> There's an option to pass -copy=false which won't copy over the sourcecode.

This *should* work, but currently doesn't because godep doesn't support
some of its functionality (the sandbox box) for bzr dependencies.

That should not stop it working when using godep restore, so
I've submitted a PR to godep to fix that
(https://github.com/tools/godep/pull/89).

With that fix, godep does pretty much what we need (but see below).

> I don't think we need to keep the external sourcecode in our repo, given
> that all our external dependencies are controlled by canonicalers (and we
> have N copies of the dependencies where N = the number of people who have
> build juju recently).

Agreed, mostly. All our external dependencies are not actually controlled
by canonicalers, but I don't think that changes the point.

For less well controlled dependencies (github.com/binary132/gojsonschema
springs to mind) we should perhaps consider forking the project
into github.com/juju.

> Definitely we should try it out and see if it fixes any of the niggles we
> have with godeps.

The main niggle there AFAIK is the fact that godeps doesn't know how
to download new dependencies. I could fix that, but I'd prefer to move
towards using a tool that's not used by us only.

Godep is by no means perfect though. It's quite slow as it updates
dependencies on a package-by-package basis rather than a repo-by-repo
basis. It also does not complain if one of the repositories you're
restoring has local changes, which could result in some awkward
situations.

Hopefully I'll be able to get some PRs to godep approved that
will help there.

  cheers,
    rog.

-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Reply via email to