I also left a review. Mostly LGTM. I just wanted a bit of feedback before giving it a ship-it. :)
-eric On Thu, Feb 25, 2016 at 8:11 AM, Andrew McDermott <andrew.mcderm...@canonical.com> wrote: > I took a quick look through it as I was OCR - comments in RB. > > On 25 February 2016 at 15:00, John Meinel <j...@arbash-meinel.com> wrote: >> >> So I have a patch up http://reviews.vapour.ws/r/3973 >> >> Which with the help from Tycho does look like it allows you to "juju >> bootstrap lxd lxd" again, but there are a fair number of caveats. >> >> The big one is that it is only compatible with lxd-2.0.0~beta4 (because >> the API has changed since beta3 and very different from 0.21/0.26). And >> currently 0.26 is the version that is in Trusty-backports. (I do see >> 2.0.0~beta4 in Xenial main, though.) >> >> For people that want to try it out, you can use ppa:ubuntu-lxc/lxd-stable >> as it has 2.0.0~beta4 in it. I'm not sure if CI will let it end up in master >> or the next Juju release because of not having 2.0.0~beta4 easily available >> in Trusty. >> >> I'll try to respond to any reviews or feedback that people give, though >> I'm technically off for the weekend. I know its one of the blockers for the >> next release, though, so I'll try to help. >> >> John >> =:-> >> >> >> -- >> Juju-dev mailing list >> Juju-dev@lists.ubuntu.com >> Modify settings or unsubscribe at: >> https://lists.ubuntu.com/mailman/listinfo/juju-dev >> > > > > -- > Andrew McDermott <andrew.mcderm...@canonical.com> > Juju Core Sapphire team <http://juju.ubuntu.com> > > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
