On 16/09/16 03:50, Nate Finch wrote: > Reviewboard goes down a couple times a month, usually from lack of disk > space or some other BS. According to a source knowledgeable with these > matters, the charm was rushed out, and the agent for that machine is down > anyway, so we're kinda just waiting for the other shoe to drop. > > As for the process things that Ian mentioned, most of those can be > addressed with a sprinkling of convention. Marking things as issues could > just be adding :x: to the first line (github even pops up suggestions and > auto-completes), thusly: > > [image: :x:]This will cause a race condition > > And if you want to indicate you're dropping a suggestion, you can use :-1: > which gives you a thumbs down: > > [image: :-1:] I ran the race detector and it's fine. > > It won't give you the cumulative "what's left to fix" at the top of the > page, like reviewboard... but for me, I never directly read that, anyway, > just used it to see if there were zero or non-zero comments left. >
If we want to do a trial, and we acknowledge that there are functional gaps, and we are prepared to work around those using convention, then we should document what those conventions are so that everyone takes a consistent approach. > As for the inline comments in the code - there's a checkbox to hide them > all. It's not quite as convenient as the gutter indicators per-comment, > but it's sufficient, I think. > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
