Reviews from Tuesday, March 24th
nrpe-external-master
Fixes a duplication issue with rsync and increases the amulet test
timeout. +1
https://code.launchpad.net/~paulgear/charms/precise/nrpe-external-master/fix-duplicate-rsync-entries/+merge/250248
<https://code.launchpad.net/%7Epaulgear/charms/precise/nrpe-external-master/fix-duplicate-rsync-entries/+merge/250248>
kibana
Add apt-get update. +1
https://code.launchpad.net/~dannf/charms/trusty/kibana/lp1428865/+merge/252132
<https://code.launchpad.net/%7Edannf/charms/trusty/kibana/lp1428865/+merge/252132>
jenkins
Fixs a typo +1 in the metadata description. +1
https://code.launchpad.net/~dannf/charms/trusty/jenkins/typo/+merge/253111
<https://code.launchpad.net/%7Edannf/charms/trusty/jenkins/typo/+merge/253111>
ubuntu
Adds a config option to create a subnet or use an existing network
interface. The README needs updating to document the new option.
https://code.launchpad.net/~cbjchen/charms/trusty/ubuntu/lxc-network-config/+merge/250666
<https://code.launchpad.net/%7Ecbjchen/charms/trusty/ubuntu/lxc-network-config/+merge/250666>
apache2
This merge syncs vhost templates from the trusty branch. There’s a lint
error being thrown to a duplicate test name. There are other test
failures, but they’re related to an open bug in trunk.
https://code.launchpad.net/~bloodearnest/charms/precise/apache2/vhost-template-vars/+merge/251268
<https://code.launchpad.net/%7Ebloodearnest/charms/precise/apache2/vhost-template-vars/+merge/251268>
https://bugs.launchpad.net/charms/+source/apache2/+bug/1401944
rabbitmq-server
This merge updates charmhelpers, adds a nagios config option and an nrpe
service check. There are issues in trunk with tests failing while
attempting to make an SSL connection unrelated to this merge. I’ve
submitted a bug against the test failures, and given my +1 to this merge.
https://code.launchpad.net/~brad-marshall/charms/trusty/rabbitmq-server/nagios-fixes-sync-charmhelpers/+merge/251551
<https://code.launchpad.net/%7Ebrad-marshall/charms/trusty/rabbitmq-server/nagios-fixes-sync-charmhelpers/+merge/251551>
https://bugs.launchpad.net/charms/+source/rabbitmq-server/+bug/1436014
postgresql
This is still a work-in-progress review. There are intermittent failures
related to a bug in juju-core and juju-deployer that I’m tracking.
https://code.launchpad.net/~stub/charms/precise/postgresql/enable-integration-tests/+merge/238283
<https://code.launchpad.net/%7Estub/charms/precise/postgresql/enable-integration-tests/+merge/238283>
https://bugs.launchpad.net/juju-deployer/+bug/1421315
-- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
