Hi, > OK, just evaluated your changes.. Thanks, > A) seems to me your jumping through hoops there. wouldn't a simple "layer > null check" with warning to the log in the unexecute() method have sufficed? Can you elaborate ? I don't think the layer is null if I don't nullify it when it is removed from the LayerManager. > B) you create a new constructor with added layer parameter. this is used only > by the tools you modded accordingly, others will probably still NPE, even > with your changes? no? Yes, there are no so many places, but I'll need to check all UndoableCommand creations. > C) i agree with the dispose refinements though Only useful to deactivate edits without truncating the queue, which is something you don't seem to agree with ?
Michaël > > ..ede > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. SALE $99.99 this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122412 > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412 _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
