[
https://issues.apache.org/jira/browse/KAFKA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221353#comment-13221353
]
Joe Stein commented on KAFKA-240:
---------------------------------
It is written to the buffer though it is not passed in when constructing the
ProducerRequest
val version_id: Short = ProducerRequest.version_id
happens during the constructor
since actual changes come in the code I though having this be on the object
leve and part of the jar the publisher was calling made the most sense. It
seemed that the client might not need or want to have this knowledge but I can
pass it into the constructor, not a problem.
Also Prashanth pointed out my member vars are not consistent with the rest of
the system and camel case I will make that change also to be consistent.
> implement new producer and consumer request format
> --------------------------------------------------
>
> Key: KAFKA-240
> URL: https://issues.apache.org/jira/browse/KAFKA-240
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: fetch, replication, wireprotocol
> Fix For: 0.8
>
> Attachments: KAFKA-240-FetchRequest-v1.patch,
> KAFKA-240-FetchRequest-v2.patch, KAFKA-240-FetchRequest-validation-v1.patch,
> KAFKA-240.ProducerRequest.v2.patch, KAFKA-240.ProducerRequest.v3.patch,
> KAFKA-240.ProducerRequest.v4.patch, KAFKA-240.v3.patch,
> kafka-240_unittestfix_delta.patch
>
>
> We want to change the producer/consumer request/response format according to
> the discussion in the following wiki:
> https://cwiki.apache.org/confluence/display/KAFKA/New+Wire+Format+Proposal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
