[ https://issues.apache.org/jira/browse/KAFKA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221452#comment-13221452 ]
Jun Rao commented on KAFKA-240: ------------------------------- Joe, When the client creates a ProduceRequest, we don't need the client to specify the version_id explicitly, since it's embedded in the client library. However, when we deserialize received bytes from a client into a ProduceRequest on the broker, we don't want to pick up the version_id that the server is on. Instead, we need to know the version of the client. So, we will need 2 constructors for ProduceRequest, one with version_id and one without. The former will be used on the broker and the latter will be used in the producer client. > implement new producer and consumer request format > -------------------------------------------------- > > Key: KAFKA-240 > URL: https://issues.apache.org/jira/browse/KAFKA-240 > Project: Kafka > Issue Type: Sub-task > Components: core > Affects Versions: 0.8 > Reporter: Jun Rao > Labels: fetch, replication, wireprotocol > Fix For: 0.8 > > Attachments: KAFKA-240-FetchRequest-v1.patch, > KAFKA-240-FetchRequest-v2.patch, KAFKA-240-FetchRequest-validation-v1.patch, > KAFKA-240.ProducerRequest.v2.patch, KAFKA-240.ProducerRequest.v3.patch, > KAFKA-240.ProducerRequest.v4.patch, KAFKA-240.v3.patch, > kafka-240_unittestfix_delta.patch > > > We want to change the producer/consumer request/response format according to > the discussion in the following wiki: > https://cwiki.apache.org/confluence/display/KAFKA/New+Wire+Format+Proposal -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira