[
https://issues.apache.org/jira/browse/KAFKA-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284161#comment-13284161
]
Joe Stein commented on KAFKA-348:
---------------------------------
<< The patch seems to miss some of the new classes created in trunk (e.g.,
KafkaStream, TopicFilter, etc).
odd, I have them local and when trying to add them I get a warning saying they
are already under version control I wonder if it is some odd svn thing not
getting picked up with the diff since the merge has them in the branch now and
svn status shows them in there so they will end up getting commited
A + core/src/main/scala/kafka/consumer/KafkaStream.scala
A + core/src/main/scala/kafka/consumer/TopicFilter.scala
along with the other added files are in svn status very weird they are not
showing through the diff... ugh will look into that but want to get these
errors cleared first
<< For addPartitionTopicInfo(currentTopicRegistry, topicDirs, partition, topic,
consumerThreadId):
<<In 0.8, the method doesn't take topicRegistry in the input any more, but uses
it in the method directly. Also, in 0.8, we are using the partitionId as the
key in the inner map of topicRegistry, instead Partition object.
thanks this is helpful going through some of the nuances I should be able to
work through these more later this evening along with the conflict for
releasePartitionOwnership
> rebase 0.8 branch from trunk
> ----------------------------
>
> Key: KAFKA-348
> URL: https://issues.apache.org/jira/browse/KAFKA-348
> Project: Kafka
> Issue Type: Task
> Affects Versions: 0.8
> Reporter: Joe Stein
> Priority: Critical
> Attachments: kafka348.patch.1.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
