[
https://issues.apache.org/jira/browse/KAFKA-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-348:
--------------------------
Attachment: kafka-348_ProducerSendThread_KafkaApis.patch
Joe,
Thanks a lot for your help. Really appreciate it. I fixed the broken unit test
and my earlier comment on converting MessageSet to ByteBufferMessageSet. To get
the fix, please
a. apply your patch
b. revert ProducerSendThread.scala and KafkaApis.scala
c. apply the new patch I attached.
Another comment. Please remove unused imports in the following classes:
BackwarsCompatibilityTest
KafkaETLContext
KafkaLog4jAppender
KafkaLog4jAppenderTest
KafkaRequetHandler
SeverShutdownTest
SimpleConsumerDemo
TestUtils
Other than that, the patch is ready for commit. Since this patch has a lot of
changes, we probably should let you commit this before kafka-46.
> rebase 0.8 branch from trunk
> ----------------------------
>
> Key: KAFKA-348
> URL: https://issues.apache.org/jira/browse/KAFKA-348
> Project: Kafka
> Issue Type: Task
> Affects Versions: 0.8
> Reporter: Joe Stein
> Priority: Critical
> Attachments: KAFKA-348.v3.notes.txt, KAFKA-348.v4.notes.txt,
> kafka-348_ProducerSendThread_KafkaApis.patch, kafka328.notes.2.txt,
> kafka348.patch.1.txt, kafka348.patch.2.txt, kafka348.patch.3.txt,
> kafka348.patch.4.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
