[ 
https://issues.apache.org/jira/browse/KAFKA-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290215#comment-13290215
 ] 

Jun Rao commented on KAFKA-341:
-------------------------------

Thanks for the patch. Some comments:

1. Can we reuse kafka-run-class.sh in root/bin instead of making a copy in 
system_test/single_host_multi_brokers/bin?

2. This test can just focus of the replication of a single cluster. We probably 
don't need to bundle the mirroring test here. So, no need to set up a target 
cluster.

3. Can we print out either PASS or FAIL at the end of the test based on the 
validation that the test does?

4. Could you write a README for the test so that people know how to run it and 
how to interpret the output?

                
> Create a new single host system test to validate all replicas on 0.8 branch
> ---------------------------------------------------------------------------
>
>                 Key: KAFKA-341
>                 URL: https://issues.apache.org/jira/browse/KAFKA-341
>             Project: Kafka
>          Issue Type: Task
>            Reporter: John Fung
>            Assignee: John Fung
>         Attachments: kafka-341-v1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to